Patch for Gnus scrolling issues

["T. V. Raman" <raman@xxxxxxxxxxx>]

LGTM, patched and checked in.


>>>>> "Tyler" == Tyler Spivey <tspivey@xxxxxxxxxxx> writes:
    Tyler> I have had issues with Gnus reading too little or too
    Tyler> much. I think that this patch solves them: 1. Patches
    Tyler> emacspeak-gnus-speak-article-body to use the
    Tyler> dimensions of the window containing the article
    Tyler> buffer.
    Tyler> 
    Tyler> 2. patches gnus-summary-prev-page and
    Tyler> gnus-summary-next-page to use move-to-window-line
    Tyler> instead of forward-line and window-height in order to
    Tyler> avoid reading too much due to the mode line being
    Tyler> included in window-height.
    Tyler> 
    Tyler> 3. Does the same to
    Tyler> gnus-summary-kill-same-subject-and-select.
    Tyler> 
    Tyler> Index: emacspeak-gnus.el
    Tyler> ===================================================================
    Tyler> --- emacspeak-gnus.el (revision 5939) +++
    Tyler> emacspeak-gnus.el (working copy) @@ -155,13 +155,16 @@
    Tyler> (emacspeak-dtk-sync) (cond ((< (count-lines
    Tyler> (point-min) (point-max)) -
    Tyler> emacspeak-gnus-large-article) +
    Tyler> emacspeak-gnus-large-article) (emacspeak-speak-buffer
    Tyler> )) (t (emacspeak-auditory-icon 'large-movement ) -
    Tyler> (let ((start (point))) - (move-to-window-line -1) -
    Tyler> (end-of-line) - (emacspeak-speak-region start
    Tyler> (point))))))) + (let ((start (point)) + (window
    Tyler> (get-buffer-window (current-buffer)))) +
    Tyler> (with-selected-window window + (save-excursion +
    Tyler> (move-to-window-line -1) + (end-of-line) +
    Tyler> (emacspeak-speak-region start (point)))))))))
    Tyler>  
    Tyler>  ;;}}} ;;{{{ Advise top-level gnus command @@ -648,8
    Tyler> +651,11 @@ (emacspeak-dtk-sync) (let ((start (point ))
    Tyler> (window (get-buffer-window (current-buffer )))) -
    Tyler> (forward-line (window-height window)) -
    Tyler> (emacspeak-speak-region start (point )))))) +
    Tyler> (with-selected-window window + (save-excursion +
    Tyler> (move-to-window-line -1) + (end-of-line) +
    Tyler> (emacspeak-speak-region start (point ))))))))
    Tyler>  
    Tyler>  (defadvice gnus-summary-kill-same-subject (after
    Tyler> emacspeak pre act) "Speak the line.  @@ -726,8 +732,11
    Tyler> @@ (set-buffer "*Article*") (let ((start (point ))
    Tyler> (window (get-buffer-window (current-buffer )))) -
    Tyler> (forward-line (window-height window)) -
    Tyler> (emacspeak-speak-region start (point ))))) +
    Tyler> (with-selected-window window + (save-excursion +
    Tyler> (move-to-window-line -1) + (end-of-line) +
    Tyler> (emacspeak-speak-region start (point )))))))
    Tyler>  
    Tyler>  (defadvice gnus-summary-prev-page (after emacspeak
    Tyler> pre act) "Speak the previous pageful " @@ -737,8
    Tyler> +746,11 @@ (set-buffer "*Article*") (let ((start
    Tyler> (point )) (window (get-buffer-window (current-buffer
    Tyler> )))) - (forward-line (- (window-height window))) -
    Tyler> (emacspeak-speak-region start (point ))))) +
    Tyler> (with-selected-window window + (save-excursion +
    Tyler> (move-to-window-line -1) + (end-of-line) +
    Tyler> (emacspeak-speak-region start (point )))))))
    Tyler>  
    Tyler>  (defadvice gnus-summary-beginning-of-article (after
    Tyler> emacspeak pre act) "Speak the first
    Tyler> line. "(save-excursion
    Tyler> 
    Tyler> -----------------------------------------------------------------------------
    Tyler> To unsubscribe from the emacspeak list or change your
    Tyler> address on the emacspeak list send mail to
    Tyler> "emacspeak-request@xxxxxxxxxxx" with a subject of
    Tyler> "unsubscribe" or "help"

-- 
Best Regards,
--raman

      
Email:  raman@xxxxxxxxxxx
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@xxxxxxxxxxx
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@xxxxxxxxxxx" with a
subject of "unsubscribe" or "help"